-
Notifications
You must be signed in to change notification settings - Fork 45
feat!: upgrade to Node 22 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Moving to draft until we have @electron/get updated first |
dsanders11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a .nvmrc file with 22.12 as the content? Then we can also update the build and release workflows to use node-version-file: '.nvmrc' so that we have fewer things to keep up-to-date. The test workflow can remain as-is with 22.12 listed since it's a matrix and we'll be extending it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the ESM conversion here as well: https://www.notion.so/electronhq/Upgrade-Checklist-17e1459d1bd180429963c3644c930f3c#1821459d1bd18095b749d61ce7759b0d
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Updated the PR with the requested changes (ESM and nvmrc). A few notes:
|
BREAKING CHANGE: This PR bumps the minimum Node.js version to 22.12.0. This package is now ESM-only.
See more details here: https://www.electronjs.org/blog/ecosystem-node-22