Skip to content

Conversation

@VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Jan 22, 2025

BREAKING CHANGE: This PR bumps the minimum Node.js version to 22.12.0. This package is now ESM-only.

See more details here: https://www.electronjs.org/blog/ecosystem-node-22

@VerteDinde
Copy link
Member Author

Moving to draft until we have @electron/get updated first

@VerteDinde VerteDinde marked this pull request as draft January 22, 2025 21:43
@VerteDinde VerteDinde marked this pull request as ready for review July 1, 2025 22:27
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a .nvmrc file with 22.12 as the content? Then we can also update the build and release workflows to use node-version-file: '.nvmrc' so that we have fewer things to keep up-to-date. The test workflow can remain as-is with 22.12 listed since it's a matrix and we'll be extending it in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electron electron deleted a comment from notion-workspace bot Jul 2, 2025
@erickzhao erickzhao self-assigned this Oct 27, 2025
@socket-security
Copy link

socket-security bot commented Oct 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​electron/​get@​2.0.2 ⏵ 4.0.199 +310010087 +7100

View full report

@erickzhao erickzhao requested a review from dsanders11 October 27, 2025 22:07
@erickzhao
Copy link
Member

Updated the PR with the requested changes (ESM and nvmrc). A few notes:

  • The APIs in this package still use callbacks instead of promises. Not sure if we want to add scope to this PR to change that.
  • I believe this will create SemVer v1.0.0 for the package according to semantic-release.

@VerteDinde VerteDinde merged commit acbc4b6 into main Oct 28, 2025
6 checks passed
@VerteDinde VerteDinde deleted the node-22 branch October 28, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants