Skip to content

chore: add AI tool policy to CONTRIBUTING.md & update PR template#50451

Open
clavin wants to merge 1 commit intomainfrom
clavin--add-ai-tool-policy
Open

chore: add AI tool policy to CONTRIBUTING.md & update PR template#50451
clavin wants to merge 1 commit intomainfrom
clavin--add-ai-tool-policy

Conversation

@clavin
Copy link
Member

@clavin clavin commented Mar 24, 2026

Description of Change

Adds links to the AI tool policy in the contributors guide and the PR template. I also took the opportunity to polish some words & squish a couple checklist items under one umbrella.

Additional Context

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 24, 2026
Comment on lines -15 to -17
- [ ] PR description included
- [ ] I have built and tested this PR
- [ ] `npm test` passes
Copy link
Member Author

@clavin clavin Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recognize that some folks might find value in having these in the template. i decided to consolidate them. the rationale is redundancy--we have concrete checks for some, and it feels like these are all different forms of us communicating the same one thing: 'are you contributing respectfully?'

(2¢: they became noisy over time with additions and makes this section's friction too high)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote against separating those.

I have built and tested this PR was added because we had the other two checks and people were still submitting stuff that they hadn't built.

Also, npm test is different from manual testing. And being able to explain the changes is different from including a description.

I think verbosity is good here. It communicates our expectations clearly, and the more opportunities we give people to self-report, the better.

It takes 5 seconds to fill out the template, but it might save a reviewer 15 minutes of reviewing a crappy PR that doesn't even build.

In my opinion, the math is in favor of verbosity here.

Comment on lines -15 to -17
- [ ] PR description included
- [ ] I have built and tested this PR
- [ ] `npm test` passes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote against separating those.

I have built and tested this PR was added because we had the other two checks and people were still submitting stuff that they hadn't built.

Also, npm test is different from manual testing. And being able to explain the changes is different from including a description.

I think verbosity is good here. It communicates our expectations clearly, and the more opportunities we give people to self-report, the better.

It takes 5 seconds to fill out the template, but it might save a reviewer 15 minutes of reviewing a crappy PR that doesn't even build.

In my opinion, the math is in favor of verbosity here.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants