chore: add AI tool policy to CONTRIBUTING.md & update PR template#50451
chore: add AI tool policy to CONTRIBUTING.md & update PR template#50451
Conversation
| - [ ] PR description included | ||
| - [ ] I have built and tested this PR | ||
| - [ ] `npm test` passes |
There was a problem hiding this comment.
i recognize that some folks might find value in having these in the template. i decided to consolidate them. the rationale is redundancy--we have concrete checks for some, and it feels like these are all different forms of us communicating the same one thing: 'are you contributing respectfully?'
(2¢: they became noisy over time with additions and makes this section's friction too high)
There was a problem hiding this comment.
I'd vote against separating those.
I have built and tested this PR was added because we had the other two checks and people were still submitting stuff that they hadn't built.
Also, npm test is different from manual testing. And being able to explain the changes is different from including a description.
I think verbosity is good here. It communicates our expectations clearly, and the more opportunities we give people to self-report, the better.
It takes 5 seconds to fill out the template, but it might save a reviewer 15 minutes of reviewing a crappy PR that doesn't even build.
In my opinion, the math is in favor of verbosity here.
| - [ ] PR description included | ||
| - [ ] I have built and tested this PR | ||
| - [ ] `npm test` passes |
There was a problem hiding this comment.
I'd vote against separating those.
I have built and tested this PR was added because we had the other two checks and people were still submitting stuff that they hadn't built.
Also, npm test is different from manual testing. And being able to explain the changes is different from including a description.
I think verbosity is good here. It communicates our expectations clearly, and the more opportunities we give people to self-report, the better.
It takes 5 seconds to fill out the template, but it might save a reviewer 15 minutes of reviewing a crappy PR that doesn't even build.
In my opinion, the math is in favor of verbosity here.
Description of Change
Adds links to the AI tool policy in the contributors guide and the PR template. I also took the opportunity to polish some words & squish a couple checklist items under one umbrella.
Additional Context
Checklist
Release Notes
Notes: none