Conversation
pmp-p
left a comment
pmp-p
left a comment
There was a problem hiding this comment.
we also need to remove all the imports/exports lists. wasi wasm-objdump is doing a good job at auto generating them and it can run anywhere wasmtime is running.
|
|
||
| ac_config_links="$ac_config_links src/backend/port/pg_sema.c:${SEMA_IMPLEMENTATION} src/backend/port/pg_shmem.c:${SHMEM_IMPLEMENTATION} src/include/pg_config_os.h:src/include/port/${template}.h src/Makefile.port:src/makefiles/Makefile.${template}" | ||
|
|
||
| ac_config_links="$ac_config_links src/include/port/wasm_common.h:src/include/port/wasm_common.h" |
There was a problem hiding this comment.
try to avoid patching configure file, this file is auto generated whenever upstream update it with autotools and makes it hard for diff to apply. prefer add changes to CONFIG_SITE when it is possible
|
|
||
| . ${PGROOT}/pgopts.sh | ||
|
|
||
| # make sure no non-mvp feature gets in. |
There was a problem hiding this comment.
some compilers will try to use cpu intrinsics by default and some of them are allowed or emulated but outside MVP which may breaks compat on mobile browsers. Better force off to keep close to wasm MVP
pglite/cibuild/pgbuild.sh
Outdated
| fi | ||
|
|
||
| if EM_PKG_CONFIG_PATH=$PREFIX/lib/pkgconfig CONFIG_SITE=${PGROOT}/config.site emconfigure $CNF --with-template=$BUILD | ||
| if EM_PKG_CONFIG_PATH=$PREFIX/lib/pkgconfig ac_cv_exeext=$ACCVEXEEXT emconfigure $CNF --with-template=$BUILD |
There was a problem hiding this comment.
please do not scatter autoconf modifiers, keep them in one file passed with CONFIG_SITE. this may be need to get homogenous build of third party libraries
2 participants
Mostly cleanups and simplifications.
Introduced a simple gh action to build postgres-pglite (postgres wasm).