devices: convert user specified device into lowercase#1
Open
shagbag913 wants to merge 1 commit intoeldainosor:masterfrom
Open
devices: convert user specified device into lowercase#1shagbag913 wants to merge 1 commit intoeldainosor:masterfrom
shagbag913 wants to merge 1 commit intoeldainosor:masterfrom
Conversation
When a user specifies a device with an uppercase letter (e.g., /device Mido), it'll tell the user that the device Mido isn't official, since none of our devices have uppercase letters in the json. To fix this and avoid confusion, convert the specified device to lowercase. Signed-off-by: shagbag913 <sh4gbag913@gmail.com>
|
hmm |
Author
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user specifies a device with an uppercase letter (e.g., /device
Mido), it'll tell the user that the device Mido isn't official, since
none of our devices have uppercase letters in the json. To fix this and
avoid confusion, convert the specified device to lowercase.
Signed-off-by: shagbag913 sh4gbag913@gmail.com