Allow to copy ptrace.c code into C++ codebase#5
Open
arkq wants to merge 3 commits intoelcritch:masterfrom
Open
Allow to copy ptrace.c code into C++ codebase#5arkq wants to merge 3 commits intoelcritch:masterfrom
arkq wants to merge 3 commits intoelcritch:masterfrom
Conversation
Using void pointers in arithmetic operations is an undefined behavior. In C++ it triggers compilation errors. Also, use "%zx" to read segment offset to properly run on 32/64 bit machines.
This will allow to seamlessly copy the ptrace.c code into the C++ codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
extern "C"to allow copying prace.c code into C++ codebasesize_tfor reading segment offset (fix void pointer arithmetic)