feat: Add CORS for Commerce Manager endpoints #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add restricted CORS middleware for CM origins:
- integration/staging/useast/euwest.cm.elasticpath.com
- localhost:3000
- Vercel preview deployments ({MR}--{env}-commerce-manager.vercel.app)
Endpoints updated:
- /api/v1/auth/self, /api/v1/auth/csrf
- /api/v1/app-config
- /api/v1/projects (list, create, clone, update, delete, meta, update-host)
- /api/v1/cmse/databases (list, create, clone, delete)
Replace hardcoded environment URLs with regex pattern for *.cm.elasticpath.com to avoid exposing internal environment names in public code.
There was a problem hiding this comment.
Pull request overview
This PR adds restricted CORS middleware to enable cross-origin requests from Commerce Manager frontends to specific API endpoints. The implementation creates a new module with origin validation that allows requests from elasticpath.com subdomains, Vercel preview deployments, and localhost:3000.
Changes:
- New CORS middleware module (
cm-cors.ts) with origin validation for Commerce Manager domains - Applied CORS middleware to authentication, app-config, projects, and CMS database endpoints
- Added preflight OPTIONS handlers for all Commerce Manager-accessible routes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| platform/wab/src/wab/server/cm-cors.ts | New CORS middleware with origin validation for Commerce Manager domains (elasticpath.com, Vercel previews, localhost) |
| platform/wab/src/wab/server/AppServer.ts | Applied cmCors middleware to auth, projects, and CMS endpoints; added cmCorsPreflight OPTIONS handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use stricter regex [a-zA-Z0-9-] instead of \w (no underscores) - Add logging for rejected origins - Use callback(null, false) instead of Error for CORS rejection - Add cmCors to missing cmse database endpoints - Add test coverage for isCmOriginAllowed function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Endpoints Updated
/api/v1/auth/self,/api/v1/auth/csrf/api/v1/app-config/api/v1/projects(list, create, clone, update, delete, meta, update-host)/api/v1/cmse/databases(list, create, clone, delete)Files Changed
platform/wab/src/wab/server/cm-cors.ts(new)platform/wab/src/wab/server/AppServer.ts