Skip to content

Nav links update #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
field123 merged 3 commits into from
Jan 26, 2026
Merged

Nav links update #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f7248e
Update build-site-navigation.ts
mzaintariq Jan 24, 2026
dc28fef
Update NavBarPopover.tsx
mzaintariq Jan 24, 2026
76c2f4a
fix key error
mzaintariq Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 21 additions & 23 deletions examples/core/src/components/header/navigation/NavBarPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,23 @@ export function NavBarPopover({
<div key={item.id} className="flex flex-col gap-3 text-sm text-gray-500">
<span className="font-semibold text-black">{item.name}</span>
{item.children.map((child: NavigationNode) => (
<LocaleLink
<NavigationMenuLink
key={child.id}
href={`/search${child.href}`}
legacyBehavior
passHref
className="hover:text-brand-primary hover:underline cursor-pointer"
onClick={(e) => {
e.preventDefault();
window.location.href = `/search${child.href}`;
}}
>
<NavigationMenuLink className="hover:text-brand-primary hover:underline">
{child.name}
</NavigationMenuLink>
</LocaleLink>
))}
<LocaleLink href={`/search${item.href}`} legacyBehavior passHref>
<NavigationMenuLink className="hover:text-brand-primary hover:underline font-semibold">
Browse All
{child.name}
</NavigationMenuLink>
</LocaleLink>
))}
<NavigationMenuLink className="hover:text-brand-primary hover:underline font-semibold cursor-pointer" onClick={(e) => {
e.preventDefault();
window.location.href = `/search${item.href}`;
}}>
Browse All
</NavigationMenuLink>
</div>
);
};
Expand All @@ -63,16 +64,13 @@ export function NavBarPopover({
)}
</div>
<hr className="my-6 border-gray-200"></hr>
<LocaleLink
href={`/search${item.href}`}
legacyBehavior
passHref
>
<NavigationMenuLink className="text-sm font-semibold hover:text-brand-primary hover:underline mb-12 flex text-black">
Browse All {item.name}
<ArrowRightIcon className="ml-1 w-4" />
</NavigationMenuLink>
</LocaleLink>
<NavigationMenuLink className="text-sm font-semibold hover:text-brand-primary hover:underline mb-12 flex text-black cursor-pointer" onClick={(e) => {
e.preventDefault();
window.location.href = `/search${item.href}`;
}}>
Browse All {item.name}
<ArrowRightIcon className="ml-1 w-4" />
</NavigationMenuLink>
</div>
</NavigationMenuContent>
</NavigationMenuItem>
Expand Down
58 changes: 34 additions & 24 deletions examples/core/src/lib/build-site-navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ function constructTree(
name: hierarchy.attributes?.name!,
id: hierarchy.id!,
slug: hierarchy.attributes?.slug,
parentName: "",
}),
)
.map(async (hierarchy) => {
Expand All @@ -72,29 +73,29 @@ function constructTree(
// Build 2nd level by finding all 'child nodes' belonging to each first level featured-nodes
const directs = directChildren.data?.data
? directChildren.data.data.slice(0, 4).map((child) => {
const children: ISchema[] = allNodes.data?.data
? allNodes.data.data
.filter(
(node) => node?.relationships?.parent?.data.id === child.id,
)
.map((node) =>
createNode({
name: node.attributes?.name!,
id: node.id!,
slug: node.attributes?.slug,
hrefBase: `${hierarchy.href}/${child.attributes?.slug}`,
}),
)
: [];
const children: ISchema[] = allNodes.data?.data
? allNodes.data.data
.filter(
(node) => node?.relationships?.parent?.data.id === child.id,
)
.map((node) =>
createNode({
name: node.attributes?.name!,
id: node.id!,
slug: node.attributes?.slug,
parentName: `${hierarchy.name} > ${child.attributes?.name}`,
}),
)
: [];

return createNode({
name: child.attributes?.name!,
id: child.id!,
slug: child.attributes?.slug,
hrefBase: hierarchy.href,
children,
});
})
return createNode({
name: child.attributes?.name!,
id: child.id!,
slug: child.attributes?.slug,
parentName: hierarchy.name,
children,
});
})
: [];

return { ...hierarchy, children: directs };
Expand All @@ -117,12 +118,21 @@ function createNode({
slug = "missing-slug",
hrefBase = "",
children = [],
}: CreateNodeDefinition): ISchema {
parentName = "",
}: CreateNodeDefinition & { parentName?: string }): ISchema {
const hierarchicalPath = parentName
? `${parentName} > ${name}`
: name;
const segments = hierarchicalPath.split(" > ").filter(Boolean);
const urlPath = segments.length > 0
? "/" + segments.map(segment => encodeURIComponent(segment)).join("/")
: "";

return {
name,
id,
slug,
href: `${hrefBase}/${slug}`,
href: `${hrefBase}/${urlPath}`,
children,
};
}