Update span enrichment to clear the span ID and span Name #254
+229
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the span enrichment to clear the span id and span name. This allows the span id and name to be only represented by the elastic attributes (
span.id,span.nameortransaction.id,transaction.name) only. The ES Exporter can then use both the elastic attributes and the SpanID and SpanName in the ECS encoder and the resulting document will contain the correct attributes based on the enrichment applied in theelasticapmprocessor/opentelemetry-lib.The
clear_span_idandclear_span_nameconfigs are disabled by default for backwards compatibility. Collectors that do not require strict parity with the apm-data flow can keep these configs disabled (example should be the EDOT collectors). Collectors that would like to closely match the apm-data behavior can enable these configs as needed.Related to: open-telemetry/opentelemetry-collector-contrib#45014 and elastic/opentelemetry-collector-components#943
Testing
processor/elasticapmconfig: