-
Notifications
You must be signed in to change notification settings - Fork 526
[azure logs] Add AMQP-over-Websockets and proxy support #16955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Supports `amqp` and `websocket` options, and allow using proxy when the `websocket` transport is selected.
transport config option|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
@lucabelluccini, this PR adds AMQP-over-WebSockets and proxy support to the Azure Logs integration. I've updated the docs, but I'm not entirely happy with how they turned out. I'd love your input on what users would expect to see here to find out that the integration now supports AMQP-over-WebSockets and proxying. |
🚀 Benchmarks reportTo see the full report comment with |
|
Thank you @zmoog ! I think we should highlight:
|
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
muthu-mps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lucabelluccini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment to clarify the support for this.
On it! |
Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
Changes: - Clarify processor v2 is required for websockets and proxy - Clarify minimum set of EA version (I would add the min version in the docs) - Highlight outbound connections
💚 Build Succeeded
History
cc @zmoog |
|
@lucabelluccini, we updated the docs, please take a look when you have time. |
lucabelluccini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
Proposed commit message
Add the new Event Hubs
transportconfig option that supportsAMQPandAMQP-over-Websocketsprotocols.The
AMQP-over-Websocketsprotocol allows reaching Event Hubs on the 443 (HTTPS) port, making the integration available in network environment with restrictions. WhenAMQP-over-Websocketsis selected, users can also route traffic through a proxy by setting theHTTPS_PROXYenvironment variable.The Event Hubs
transportconfig option requires stack versions 8.19.10, 9.1.10 and 9.2.4.Checklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
Related issues
Screenshots
UI
Docs