Skip to content

Conversation

@ezzamo
Copy link
Contributor

@ezzamo ezzamo commented Jan 7, 2026

Proposed commit message

eset_protect: align batch_size with ESET API max (1000)

WHAT

This PR updates the eset_protect package configuration to align the batch_size (page size) setting with the maximum supported value documented in the ESET Connect API specification.

Concretely:

  • Update batch_size description to reflect the API maximum (1000).
  • Set the default batch_size to 1000 to avoid requesting an unsupported page size.

WHY

The ESET Connect API Swagger documentation for the relevant endpoints specifies a maximum page size of 1000. The package configuration previously allowed larger values. Although the documentation mentions that larger values are coerced to “1000”, it is best to align the configuration with the specification.

References:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices.

How to test this PR locally

From the integrations repo:

  • cd packages/eset_protect
  • elastic-package lint
  • elastic-package build

upload it in kibana

Related issues

  • N/A

@ezzamo ezzamo requested a review from a team as a code owner January 7, 2026 19:46
@andrewkroh andrewkroh added Integration:eset_protect ESET PROTECT Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 8, 2026
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:eset_protect ESET PROTECT Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants