eset_protect: align batch_size config with ESET API spec #16896
+10
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT
This PR updates the
eset_protectpackage configuration to align thebatch_size(page size) setting with the maximum supported value documented in the ESET Connect API specification.Concretely:
batch_sizedescription to reflect the API maximum (1000).batch_sizeto 1000 to avoid requesting an unsupported page size.WHY
The ESET Connect API Swagger documentation for the relevant endpoints specifies a maximum page size of 1000. The package configuration previously allowed larger values. Although the documentation mentions that larger values are coerced to “1000”, it is best to align the configuration with the specification.
References:
https://eu.esetconnect.eset.systems/swagger/?urls.primaryName=Automation#/DeviceTasks/DeviceTasks_ListTasks
https://eu.esetconnect.eset.systems/swagger/?urls.primaryName=Incident%20Management
Checklist
How to test this PR locally
From the integrations repo:
cd packages/eset_protectelastic-package lintelastic-package buildupload it in kibana
Related issues