Update Norway counties to match GeoIP subdivision codes#570
Open
jsanz wants to merge 4 commits intofeature-layersfrom
Open
Update Norway counties to match GeoIP subdivision codes#570jsanz wants to merge 4 commits intofeature-layersfrom
jsanz wants to merge 4 commits intofeature-layersfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Adds 3 merged features (NO-34 Innlandet, NO-42 Agder, NO-46 Vestland) alongside all original pre-2020 features so that any GeoIP database version produces matching geometries. Served as default for Kibana 8+, while 7.x continues to use v1. Co-authored-by: Cursor <cursoragent@cursor.com>
Set FID in the dissolve calc expression so mapshaper preserves the GeoJSON feature id for the 3 merged counties. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
norway_counties_v2.geo.jsonwith 23 features: all 20 original pre-2020 counties plus 3 merged 2020 counties (NO-34 Innlandet, NO-42 Agder, NO-46 Vestland)Changes
sources/no/counties.hjson>=1to1 - 7sources/no/counties_v2.hjson>=8pointing to v2sources/no/Makefiledata/norway_counties_v2.geo.jsonsources/no/README.mdsources/no/GEOIP_INVESTIGATION.mdBackground
MaxMind updated their GeoLite2-City database in March 2024 to reflect Norway's county splits. They use a hybrid of pre-2020 codes (for split-back counties) and 2020 codes (for still-merged counties). The current EMS v1 data was missing 3 codes that GeoIP now returns (NO-34, NO-42, NO-46). Full investigation details in
sources/no/GEOIP_INVESTIGATION.md.Verification
yarn test: 722 tests, 717 pass, 5 skip, 0 failuresyarn build: v7.16 manifest references v1 (20 features), v8.0+ manifests reference v2 (23 features)yarn lint: cleanCloses #565