Remove TODO in a test for verifying start of the week#50894
Merged
pgomulka merged 7 commits intoelastic:masterfrom Jan 21, 2020
Merged
Remove TODO in a test for verifying start of the week#50894pgomulka merged 7 commits intoelastic:masterfrom
pgomulka merged 7 commits intoelastic:masterfrom
Conversation
We cannot change the default of what a start of the week is in JDK8 which is supported by 6.x. Therefore This test will only run against 7.x
pgomulka
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Contributor
Author
|
ok to test |
Contributor
|
There's a test failure that looks like it may be related to the change? |
Contributor
Author
|
@pugnascotia yes, the required jvm flag was accidentally removed. Fix here #50916 |
Contributor
Author
|
@elasticmachine update branch |
pugnascotia
approved these changes
Jan 21, 2020
nik9000
approved these changes
Jan 21, 2020
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM. Thanks for clearing the TODO!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test should be run against 7.7 version at least, as this was only backported and released in that version
relates SPI based implementation #48209
relates backport #48349