Change default locale of date processors to ENGLISH#112796
Merged
thecoop merged 2 commits intoelastic:mainfrom Sep 24, 2024
Merged
Change default locale of date processors to ENGLISH#112796thecoop merged 2 commits intoelastic:mainfrom
thecoop merged 2 commits intoelastic:mainfrom
Conversation
thecoop
added
>bug
:Distributed/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
Team:Data Management (obsolete)
Collaborator
|
Hi @thecoop, I've created a changelog YAML for you. |
Collaborator
|
Hi @thecoop, I've updated the changelog YAML for you. Note that since this PR is labelled |
Member
Author
Member
|
@elasticmachine update branch |
thecoop
force-pushed
the
english-date-processors
branch
from
fd80a1a to
0f51fd1
Compare
joegallo
approved these changes
Sep 23, 2024
Contributor
joegallo
left a comment
joegallo
left a comment
There was a problem hiding this comment.
Ship it!
We'll need to add a docs PR that fixes the previously-wrong documentation on pre-8.16 branches. That is, we documented that the default locale for date processors was english, but it's always been root. I'll take that as a task for 8.16.
Member
Author
|
@elasticmachine update branch |
thecoop
added
the
auto-backport
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 24, 2024
It is English in the docs, so this fixes the code to match the docs. Note that this really impacts Elasticsearch when run on JDK 23 with the CLDR locale database, as in the COMPAT database pre-23, root and en are essentially the same.
Collaborator
💚 Backport successful
|
thecoop
added a commit
that referenced
this pull request
Sep 24, 2024
It is English in the docs, so this fixes the code to match the docs. Note that this really impacts Elasticsearch when run on JDK 23 with the CLDR locale database, as in the COMPAT database pre-23, root and en are essentially the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #112692
Field mappers are covered by #112799