Optimize to_pandas() internally to improve performance #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_es_resultsis a duplicate ofsearch_yield_pandas_dataframes.In
_es_resultsWe are directly dumping the ES data into a List[...] and then converting into apd.Dfwhich is time taking on larger datasets because we must dump all the data before we start any processingSo, if we internally Iterate over the results and parallelly convert data into df and concatenate them at last. It improves the performance.
Further Performance will be improved once this PR + #389 are merged.
Right now, the metrics are as follows for nyc-restaurants:
@sethmlarson Take a look :)