Regenerate ECS 9.3.0 and fix generator for new field types#548
Merged
Regenerate ECS 9.3.0 and fix generator for new field types#548
Conversation
- Add `double` to FieldType enum for new gen_ai fields (e.g. frequency_penalty) - Add `TrySetInt` to PropDispatch for integer field type dispatch - Fix XML doc comment escaping: escape all `&` chars, not just `ATT&CK` - Fix entity converter accessibility: use CodeConfiguration to control public vs internal for generated partial classes (Ecs, Log are public) - Fix PropDispatch template to skip entries with null CastFromObject (arrays, geo_point) preventing broken tuple expressions - Return null from GetCastFromObject for GeoPoint (Location is a complex type, not assignable via TrySetString) - Include v9.3.0 specification download
🤖 GitHub commentsJust comment with:
|
ECS 9.3.0 added new field sets (gen_ai, entity, etc.) pushing past the previous 2500 limit during integration test indexing.
Instead of hardcoding the total_fields limit in the spec template (which gets overwritten on re-download), compute it from the actual field count with 50% headroom for multi-fields, internal fields, and dynamic mappings.
reakaleek
approved these changes
Feb 17, 2026
gregkalapos
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doubleto FieldType enum for new gen_ai fields (e.g. frequency_penalty)TrySetIntto PropDispatch for integer field type dispatch&chars, not justATT&CKpublic vs internal for generated partial classes (Ecs, Log are public)
(arrays, geo_point) preventing broken tuple expressions
type, not assignable via TrySetString)