Merged
Conversation
Member
Mpdreamz
commented
Nov 13, 2025
Mpdreamz
commented
- Migrate to .NET 10
- move to slnx
- update tools and scripts
🤖 GitHub commentsJust comment with:
|
v1v
previously approved these changes
Nov 13, 2025
Contributor
|
Possible to also update NLog from ver. 6.0.2 to 6.0.3 (Includes an important bugfix for NLog FileTarget). For those using NLog EcsLayout for writing to local file. |
…0 compatibility The Elastic.Apm agent internally accesses collection properties like TransactionNameGroups, TransactionIgnoreUrls, and others without null checks. On .NET 10 these null values cause NullReferenceException in Transaction.End(). Also set TransactionSampleRate to 1.0 (matching the agent's default) so transactions are properly sampled during tests.
- Update GitHubActionsTestLogger from 2.4.1 to 3.0.1 for .NET 10 support - Fix logger friendly name casing (GithubActions -> GitHubActions) - Add GitHubActionsTestLogger to tests-integration Directory.Build.props - Remove junit XML artifact upload steps (no junit logger configured) - Remove test-reporter workflow (depended on junit artifacts) - Remove junit cleanup from build teardown
.NET 10's DefaultJsonTypeInfoResolver no longer picks up inherited [JsonConverter] attributes from base classes. Add the attribute explicitly to EcsDocument subclasses so the EcsDocumentJsonConverterFactory is used regardless of serialization path. Use unique data stream names in integration tests to avoid collisions when the test framework executes tests concurrently.
Same double-execution fix as data stream tests - the test framework runs each test twice concurrently against the same cluster, so index names need to be unique per execution to avoid template conflicts.
The ElasticTestFramework runs each test twice with the same test case IDs, causing GitHubActionsTestLogger to crash with "Key already exists in the message metadata cache". This makes VSTestTask report failure even when all tests pass.
The solution-level dotnet test loads loggers from all assemblies globally. The logger from unit test projects was crashing on duplicate test IDs produced by the ElasticTestFramework in integration tests.
…sTestLogger 0.11.0 fixes the double test execution that caused GitHubActionsTestLogger to crash with duplicate test case IDs. Restore the logger and --logger arg now that the root cause is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.