-
Notifications
You must be signed in to change notification settings - Fork 194
Introduce downsampling methods #4631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vale Linting ResultsSummary: 1 suggestion found 💡 Suggestions (1)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🔍 Preview links for changed docs |
|
|
||
| * Set `fixed_interval` to your preferred level of granularity. The original time series data will be aggregated at this interval. | ||
| * Set `after` to the minimum time to wait after an index rollover, before running downsampling. | ||
| * (Optional) Set `downsampling_method` to your preferred [downsampling method](/manage-data/data-store/data-streams/downsampling-concepts.md#downsampling-methods), or leave it unspecified to use the default method (`aggregate`). {applies_to}`stack: preview 9.3` {applies_to}`serverless: ga` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if this is a silly question: I find the applies_to tag a bit confusing, are we trying to indicate that starting with 9.3 the default method is aggregate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, no this specific configuration option is introduced in 9.3. Is there a recommended way to do that, or do I need to change format of this paragragh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right! Maybe just try adding it at the start of the list item?
| * (Optional) Set `downsampling_method` to your preferred [downsampling method](/manage-data/data-store/data-streams/downsampling-concepts.md#downsampling-methods), or leave it unspecified to use the default method (`aggregate`). {applies_to}`stack: preview 9.3` {applies_to}`serverless: ga` | |
| * {applies_to}`stack: preview 9.3` {applies_to}`serverless: ga` (Optional) Set `downsampling_method` to your preferred [downsampling method](/manage-data/data-store/data-streams/downsampling-concepts.md#downsampling-methods), or leave it unspecified to use the default method (`aggregate`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this way is clearer that the tags apply to the entire option perhaps. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * (Optional) Set `downsampling_method` to your preferred [downsampling method](/manage-data/data-store/data-streams/downsampling-concepts.md#downsampling-methods), or leave it unspecified to use the default method (`aggregate`). {applies_to}`stack: preview 9.3` {applies_to}`serverless: ga` | |
| * (Optional) {applies_to}`stack: preview 9.3` {applies_to}`serverless: ga` Set `downsampling_method` to your preferred [downsampling method](/manage-data/data-store/data-streams/downsampling-concepts.md#downsampling-methods), or leave it unspecified to use the default method (`aggregate`). |
Or maybe here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it's more clear this way. I will check the options to see how it looks. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
yetanothertw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your work on this! 🎉

Summary
In this PR we document the downsampling methods and their configuration (see elastic/elasticsearch#128357).
Generative AI disclosure
Google Gemini