Update workflows to automatically handle all branches with directory checks #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove explicit branch list from pull_request trigger - Add condition to skip workflow when PR targets main branch - This avoids needing to maintain branch list for each new/deprecated version
- Remove explicit branch list from push trigger - Use branches-ignore to exclude main branch - Workflow now triggers on pushes to all branches except main
- Add branches-ignore: ['main'] to pull_request trigger - Remove unnecessary condition from build job - Both push and pull_request now consistently exclude main at the trigger level
…t main - Remove explicit branch lists from push and pull_request triggers - Add branches-ignore: ['main'] to both triggers for consistency - Workflows now automatically work for all version branches without manual updates
jmlrt
changed the title
- Remove branches-ignore from pull_request (not reliable for PR events) - Add job-level condition to skip when PR targets main - Condition handles both push and pull_request events correctly
- Add check step to verify dockerfile directory exists before building - Skip build step if directory doesn't exist (e.g., on main branch or PRs based on main) - Prevents workflow failures when directories are not present
- Remove job-level condition since directory check handles all cases - Keep branches-ignore for push to prevent unnecessary workflow runs on main - Directory existence check is now the single source of truth for builds
- Remove branches-ignore from push trigger - Directory existence check is now the single source of truth - Simpler and more maintainable - no need to maintain branch exclusion logic
- Add comment explaining directory check is needed because main branch doesn't contain Dockerfiles - Reference README.md for branch model documentation - Improves code maintainability and understanding
jmlrt
changed the title
jmlrt
requested review from
StamatisKourk and
alina-bacalete
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all three product workflows (elasticsearch, kibana, and logstash) to automatically work with all branches without requiring manual branch list maintenance.
Changes
pushandpull_requesttriggersBenefits
How it works
All three workflows (elasticsearch, kibana, and logstash) are now consistently configured and will automatically work for any version branch without requiring manual updates.