celfmt: fix idempotency and comment preservation in nested expressions #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formatting a ternary condition that needed parentheses,
visitMaybeNested decided whether to use multiline format based only on
whether the expression spans multiple lines. This failed when comments
precede a sub-expression rather than the top-level expression being
wrapped.
For example, in:
(
// comment
has(state.a) && state.b > 0
) ?
The comments are associated with the has(...) sub-expression, not the
entire && expression. The formatter would write "(" without a newline,
then the sub-expression would write the comments, resulting in:
(// comment
Running celfmt again would progressively eat comments because they
ended up on a line starting with "(" which is not recognized as a
comment line.
The fix modifies visitMaybeNested to check if the expression or any of
its descendants have preceding comments when deciding whether to use
multiline format. This ensures proper newline insertion after "(" when
comments will be written by any descendant expression.
Fixes #58
efd6
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
Please take a look.
fixes #58
Work done in conjunction with Cursor.