Fix outcome definition in error-tracking.md#824
Draft
gregkalapos wants to merge 1 commit intoelastic:mainfrom
Draft
Fix outcome definition in error-tracking.md#824gregkalapos wants to merge 1 commit intoelastic:mainfrom
outcome definition in error-tracking.md#824gregkalapos wants to merge 1 commit intoelastic:mainfrom
Conversation
Fix `outcome` description to match other parts of the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
error-tracking.mdthe definition of howoutcomeis set contradicted what we define in tracing-transactions.md and in tracing-spans.md, especially the following:This PR changes
error-tracking.mdto make it match theoutcomedefinition from other parts of the spec (see links above). I think most agents already do this according to tracing-transactions.md and tracing-spans.md - so I expect we won't need to change any implementation in a specific agent.If that's not the case, please raise it and let's discuss.
CODEOWNERS)To auto-merge the PR, add
/schedule YYYY-MM-DDto the PR description.