Skip to content

feat: add typing on some public api functions#1987

Open
pbabics wants to merge 1 commit intoelastic:mainfrom
pbabics:feat/typing
Open

feat: add typing on some public api functions#1987
pbabics wants to merge 1 commit intoelastic:mainfrom
pbabics:feat/typing

Conversation

@pbabics
Copy link
Copy Markdown

@pbabics pbabics commented Mar 6, 2024

What does this pull request do?

  • Adds typing on some of the publicly exposed API functions
  • Explicitly export API in __init__.py

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Mar 6, 2024

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Mar 6, 2024
@xrmx
Copy link
Copy Markdown
Member

xrmx commented Mar 6, 2024

Thanks for the PR. We should probably add some mypy run in CI to check we are not messing up anything.

@pbabics pbabics force-pushed the feat/typing branch 3 times, most recently from cb9d158 to c5f4cfc Compare March 7, 2024 08:16
@pbabics
Copy link
Copy Markdown
Author

pbabics commented Mar 7, 2024

Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing

@xrmx
Copy link
Copy Markdown
Member

xrmx commented Mar 8, 2024

Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing

Right, maybe we can think of an incremental strategy for typing. Let me think about it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants