fix(ecleanse) v2.2.8 convert stunman to CMan.use

[Deysh]

Important

Convert stunmaneuvers to CMan.use in ecleanse.lic, updating stun handling and version to 2.2.8.

• Behavior:
  • Convert stunmaneuvers to CMan.use in remove_stun and stunman_perform methods.
  • Update version to 2.2.8 in ecleanse.lic.
• Functions:
  • Replace fput with CMan.use for stance1, stance2, flee, and hide in stunman_perform.
  • Use CMan.available? to check for Stun Maneuvers in remove_stun.

^{This description was created by for a5a0893. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to a5a0893 in 1 minute and 30 seconds. Click for details.

• Reviewed 101 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. scripts/ecleanse.lic:1315

• Draft comment:
  Conversion to CMan.use('stunman', type) for 'stance1'/'stance2' looks clear. Ensure that CMan.use correctly mimics the old fput behavior for these maneuvers.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the author to ensure that a specific behavior is mimicked correctly. It is not a specific code suggestion or a request for a test, but rather a general request to verify behavior. This violates the rule against asking the author to ensure behavior is intended.

2. scripts/ecleanse.lic:1323

• Draft comment:
  In the 'flee' branch, the loop calls CMan.use('stunman', 'flee') and then switches to 'stance2' after the loop. Verify that automatically switching to stance2 after fleeing is the intended behavior.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify if the behavior of switching to stance2 after fleeing is intended. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.

3. scripts/ecleanse.lic:1337

• Draft comment:
  The stunman_stand loop now uses CMan.use('stunman', 'stand') without an explicit iteration limit. Consider adding a maximum iteration count to guard against an infinite loop if the stunned state persists.
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_OX0IrxjGufGe4YTR

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}