ui: change schedule toggle and note message ui#552
ui: change schedule toggle and note message ui#552mohitmadaan-rgb wants to merge 2 commits intodevfrom
Conversation
mohitmadaan-rgb
commented
Apr 8, 2026
mohitmadaan-rgb
commented
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FundTransferStep and LoadWalletStep components. Changes include adding a 'Schedule Transfer' UI section with a toggle, updating the submission logic to require the schedule state, and improving the info alerts in the LoadWalletStep by adding direct download links for the DigiKhata app. Regarding the review feedback, the logic change in 'canSubmit' that mandates 'isSchedule' to be true appears to be a functional bug if the intention is to allow transfers when the schedule toggle is disabled.
| isPinComplete && | ||
| isAmountValid && | ||
| !isSendingTransactionOtp && | ||
| isSchedule; |
There was a problem hiding this comment.
The canSubmit logic now requires isSchedule to be true. If isSchedule is a toggle that the user can turn off, this logic will prevent the user from submitting a transfer when isSchedule is false. This seems to be a functional bug if the intention is to allow transfers regardless of the schedule toggle state.
1 participant
