Skip to content

Dev#548

Merged
shubhmjain30 merged 2 commits intomainfrom
dev
Apr 8, 2026
Merged

Dev#548
shubhmjain30 merged 2 commits intomainfrom
dev

Conversation

@shubhmjain30
Copy link
Copy Markdown
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

🚨 Checklist:

  • Make sure you are requesting to pull your topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against our dev branch (left side). Also, you should start your branch off our dev branch.
  • Your code follows the code style of this project.
  • Your change requires a change to the documentation.
  • You have updated the documentation accordingly.
  • You have read the Contributing Guide.
  • You have self-reviewed your code.
  • You have added unit-tests that prove my fix is effective or that my feature works.
  • Lint and unit-tests pass locally with your changes.
  • You have added necessary comments for complex logic.
  • Any dependent changes have been merged and published in downstream modules.

Further comments

🙏 Thank you!

Thank you for contributing to this project. We appreciate your time and effort. 🎉

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wlc-webapp Ready Ready Preview, Comment Apr 8, 2026 2:07pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
satin-uat Ignored Ignored Apr 8, 2026 2:07pm

Request Review

@shubhmjain30 shubhmjain30 merged commit 0a416e1 into main Apr 8, 2026
7 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an informational alert to the LoadWalletStep component to guide users on obtaining a DigiKhata Virtual Account. The review suggests refactoring the new alert and an existing similar alert into a single reusable component to improve maintainability and reduce code duplication.

Comment on lines +364 to +377
<Alert status="info" borderRadius="10" mb={3}>
<AlertIcon />
<Box>
<Text fontWeight="semibold" fontSize="sm">
Don't have a DigiKhata Virtual Account yet?
</Text>
<Text fontSize="sm" color="light">
To get your Virtual Account, download the{" "}
<strong>DigiKhata app</strong>, register
yourself, and find your Virtual Account from the
app.
</Text>
</Box>
</Alert>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This Alert component is very similar to the one used for the UPI section (lines 275-287). To improve maintainability and reduce code duplication, consider creating a reusable component that can be used in both places.

For example, you could create a RegistrationPrompt component:

const RegistrationPrompt = ({ accountType, accountIdentifier }: { accountType: string, accountIdentifier: string }) => (
  <Alert status="info" borderRadius="10" mb={3}>
    <AlertIcon />
    <Box>
      <Text fontWeight="semibold" fontSize="sm">
        Don't have a DigiKhata {accountType} yet?
      </Text>
      <Text fontSize="sm" color="light">
        To get your {accountIdentifier}, download the{" "}
        <strong>DigiKhata app</strong>, register yourself, and find your{" "}
        {accountIdentifier} from the app.
      </Text>
    </Box>
  </Alert>
);

You could then use it here as:
<RegistrationPrompt accountType="Virtual Account" accountIdentifier="Virtual Account" />

And refactor the existing alert for UPI to use:
<RegistrationPrompt accountType="VPA" accountIdentifier="VPA ID" />

This would make the code more DRY (Don't Repeat Yourself) and easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants