Add some Deferrable extras #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* More constraint tuple instances, because we can. * A nice default definition for never-satisfiable constraints, and a stupidly boring always-satisfiable one for symmetry.
RyanGlScott
reviewed
May 10, 2018
Collaborator
RyanGlScott
left a comment
RyanGlScott
left a comment
There was a problem hiding this comment.
This seems plausible, although I have some questions inline.
| AllC '[] = () | ||
| AllC (c ': cs) = (c, AllC cs) | ||
|
|
||
| type family AllD (cs :: [Constraint]) :: Constraint where |
Collaborator
There was a problem hiding this comment.
Why is this here? It appears to be unused, from what I can tell.
|
|
||
| -- | A good definition of 'deferEither' for a constraint that is always | ||
| -- satisfiable. | ||
| deferEitherSuccess :: p => proxy p -> (p => r) -> Either String r |
Collaborator
There was a problem hiding this comment.
This could be used to implement the Deferrable () instance, right? Why not do so?
| Rank2Types, | ||
| GADTs | ||
|
|
||
| ghc-options: -fconstraint-solver-iterations=0 |
Collaborator
There was a problem hiding this comment.
Why is this here? This deserves at least a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a stupidly boring always-satisfiable one for symmetry.