Skip to content

Improve ball-ball collision handling for edge cases #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekiefl merged 24 commits into from
Jan 27, 2026

Address rabbitai review

9828421
Select commit
Loading
Failed to load commit list.
Merged

Improve ball-ball collision handling for edge cases #257

Address rabbitai review
9828421
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 27, 2026 in 1s

45.98% (+1.76%) compared to 0e89b7f

View this Pull Request on Codecov

45.98% (+1.76%) compared to 0e89b7f

Details

Codecov Report

❌ Patch coverage is 62.06897% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.98%. Comparing base (0e89b7f) to head (9828421).
⚠️ Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
pooltool/evolution/event_based/simulate.py 35.41% 31 Missing ⚠️
pooltool/ptmath/roots/quadratic.py 14.28% 24 Missing ⚠️
pooltool/evolution/event_based/solve.py 0.00% 13 Missing ⚠️
pooltool/physics/resolve/transition/__init__.py 20.00% 4 Missing ⚠️
pooltool/layouts.py 86.95% 3 Missing ⚠️
pooltool/ptmath/utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   44.22%   45.98%   +1.76%     
==========================================
  Files         127      144      +17     
  Lines        8554    10231    +1677     
==========================================
+ Hits         3783     4705     +922     
- Misses       4771     5526     +755

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov