Skip to content

fix: changed background, more optimization #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejminguez merged 1 commit into from
Jul 11, 2025
Merged

fix: changed background, more optimization #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const App = () => {
}, []);

useGSAP(() => {
// Only load ScrollSmoother on desktop for better performance
if (!isMobile) {
import("gsap/ScrollSmoother").then(({ ScrollSmoother }) => {
import("gsap/ScrollTrigger").then(({ ScrollTrigger }) => {
Expand All @@ -31,9 +30,9 @@ const App = () => {
ScrollSmoother.create({
wrapper: "#smooth-wrapper",
content: "#smooth-content",
smooth: 1.5, // Reduced from 2 for better performance
smooth: 1.5,
effects: true,
smoothTouch: 0.1, // Reduced for mobile performance
smoothTouch: 0.1,
});
});
});
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/components/Home/Greetings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const Greetings = () => {
loopTyping();
}, []);
return (
<section className="relative min-h-screen flex flex-col items-center">
<div className="flex flex-col items-center text-center">
<section className="relative min-h-[300px] flex flex-col justify-center">
<div className="flex flex-col text-center">
<h1 className="font-lore text-[3rem] text-habilin-red">
<span ref={typewriterRef} />
</h1>
Expand All @@ -44,14 +44,14 @@ const Greetings = () => {
<img
src={flower4}
loading="lazy"
className="absolute top-[30%] -right-[30%] animate-[spin_50s_linear_infinite]"
className="absolute top-[65%] -right-[30%]"
width={150}
height={150}
/>
<img
src={flower4}
loading="lazy"
className="absolute -top-[30%] -left-[25%] animate-[spin_20s_linear_infinite]"
className="absolute -top-[50%] -left-[25%]"
width={200}
height={200}
/>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/Home/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ const Hero = () => {
<img
src={flower2}
loading="lazy"
className="absolute top-[25%] right-[50%] rotate-6 -z-50 scale-150"
width={300}
height={300}
className="absolute top-[25%] right-[50%] rotate-6 -z-50"
width={700}
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using a fixed width of 700px for this image may impact performance or responsiveness; consider using responsive sizing or optimized assets.

Copilot uses AI. Check for mistakes.
height={700}
/>
<img
src={flower1}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Home/HomeBucketList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const HomeBucketList = () => {
fetchList();
}, []);
return (
<section className="flex flex-col w-full min-h-screen justify-center">
<section className="flex flex-col w-full justify-center">
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There are two spaces between w-full and justify-center in the className; consider removing the extra space for consistency.

Suggested change
<section className="flex flex-col w-full justify-center">
<section className="flex flex-col w-full justify-center">

Copilot uses AI. Check for mistakes.
<h1 className="text-[3rem] font-reenie text-right">pangarap</h1>
{loading ? (
<p>Loading ...</p>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Home/Letters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const Letters = () => {
}, []);

return (
<section className="flex flex-col w-full h-full min-h-screen justify-center">
<section className="flex flex-col w-full justify-center">
<h1 className="text-[3rem] font-reenie">liham</h1>
{loading ? (
<div className="flex items-center justify-center h-[60vh]">
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Home/MusicPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useGlobalAudioManager } from "@/hooks/useGlobalAudioManager";
const MusicPlayer = () => {
const { currentSong } = useGlobalAudioManager();
return (
<section className="relative flex flex-col min-h-screen justify-center">
<section className="relative flex flex-col justify-center">
<div className="flex flex-col items-center gap-5">
<div>
<img
Expand Down
6 changes: 1 addition & 5 deletions frontend/src/components/Letter/LetterList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const LetterList = () => {

console.log("Found cards:", cards.length); // Debug log
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this debug console.log statement before merging to keep production logs clean.

Suggested change
console.log("Found cards:", cards.length); // Debug log
// Debug log removed to keep production logs clean

Copilot uses AI. Check for mistakes.

cards.forEach((card, index) => {
cards.forEach((card) => {
gsap.fromTo(
card,
{ opacity: 0, y: 50 },
Expand All @@ -59,15 +59,11 @@ const LetterList = () => {
start: "top 85%",
end: "bottom 15%",
toggleActions: "play reverse play reverse",
// markers: true, // enable this for scroll debug
onEnter: () => console.log(`Card ${index} entered`), // Debug log
onLeave: () => console.log(`Card ${index} left`), // Debug log
},
},
);
});

// Refresh ScrollTrigger to recalculate positions
ScrollTrigger.refresh();
}, containerRef);

Expand Down
7 changes: 1 addition & 6 deletions frontend/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,7 @@
}

body {
background-size: cover;
background-repeat: no-repeat;
background-position: center;
background-attachment: fixed;
background-color: #cbe87b;
background-image: url(http://www.transparenttextures.com/patterns/textured-paper.png);
background-color: #c1e1c1;
}

@theme inline {
Expand Down
1 change: 0 additions & 1 deletion frontend/src/pages/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const Home = () => {
useGSAP(() => {
gsap.registerPlugin(ScrollTrigger, ScrollSmoother);

// Create ScrollSmoother
ScrollSmoother.create({
wrapper: "#smooth-wrapper",
content: "#smooth-content",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Playlist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Queue from "@/components/Playlist/Queue";

const Playlist = () => {
return (
<section className="relative top-[20vh]">
<section className="relative top-[20vh] mb-40">
<HeroText
title="himig"
subtitle="the songs that speak when words fall short"
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/router/router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { createBrowserRouter } from "react-router-dom";
import { lazy, Suspense } from "react";
import App from "@/App.tsx";
import ErrorNotFound from "@/pages/ErrorNotFound.tsx";
import flower4 from "@/assets/pictures/flower-4-medium.webp";

// Lazy load page components
const Home = lazy(() => import("@/pages/Home.tsx"));
Expand All @@ -13,7 +14,7 @@ const Pangarap = lazy(() => import("@/pages/Pangarap"));
// Loading component
const PageLoader = () => (
<div className="flex items-center justify-center min-h-screen">
<div className="animate-spin rounded-full h-8 w-8 border-b-2 border-gray-900"></div>
<img src={flower4} width={80} height={80} className="animate-spin" />
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an alt attribute to this spinner image for accessibility, e.g., alt="Loading" or alt="" if decorative.

Suggested change
<img src={flower4} width={80} height={80} className="animate-spin" />
<img src={flower4} width={80} height={80} className="animate-spin" alt="Loading" />

Copilot uses AI. Check for mistakes.
</div>
);

Expand Down