Skip to content

Use u64 in Raders twiddle calculations#164

Merged
ejmahler merged 6 commits intoejmahler:masterfrom
HEnquist:32bit_raders_fix
Sep 18, 2025
Merged

Use u64 in Raders twiddle calculations#164
ejmahler merged 6 commits intoejmahler:masterfrom
HEnquist:32bit_raders_fix

Conversation

@HEnquist
Copy link
Copy Markdown
Contributor

No description provided.

@ejmahler
Copy link
Copy Markdown
Owner

ejmahler commented Sep 6, 2025

Looks like maybe the commands available to the CI are different somehow, meaning the script we've been using to test webassembly doesn't work.

That probably doesn't need to block this PR, since I'm not worried about this PR breaking webassembly SIMD tests

@HEnquist
Copy link
Copy Markdown
Contributor Author

HEnquist commented Sep 6, 2025

Yes something must have changed very recently, the run from just a few days ago finished just fine.

@LukasWuethrich
Copy link
Copy Markdown

What's next?
I would like to help, but my knowledge is probably insufficient. But let me know if there's anything I can do to contribute.

@HEnquist
Copy link
Copy Markdown
Contributor Author

We need to figure out why the wasm test fails. For some reason the command wasm-pack test --node --lib --features wasm_simd no longer works on nightly. The jobs with beta and stable were cancelled so I don't know if they would have failed too.
Specifically it complains about the --lib argument. A good start would be to check if it has been removed or renamed.

@ejmahler ejmahler merged commit 03af8c1 into ejmahler:master Sep 18, 2025
19 checks passed
@ejmahler
Copy link
Copy Markdown
Owner

The --lib argument itself was a workaround for the fact that wasm-pack was incorrectly picking up some non-public comments as doctests. So I just removed the backticks from those comments and removed the --lib argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants