fix: correct misleading comment about fh_out remapping and fix fmt#552
Closed
claude-claude[bot] wants to merge 1 commit intofuse-pipe-restorefrom
Closed
fix: correct misleading comment about fh_out remapping and fix fmt#552claude-claude[bot] wants to merge 1 commit intofuse-pipe-restorefrom
claude-claude[bot] wants to merge 1 commit intofuse-pipe-restorefrom
Conversation
The comment on with_fh() for CopyFileRange/RemapFileRange incorrectly claimed "the EBADF retry in RemapFs handles one handle at a time via fh()" — but fh() only returns fh_in, and no code path ever remaps fh_out. Updated the comment to accurately document this as a known limitation with a TODO for future work. Also fixes a pre-existing cargo fmt issue in remap.rs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Not needed - comment fix cherry-picked directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #549
Issues Fixed
with_fh()for CopyFileRange/RemapFileRange — The comment incorrectly claimed "the EBADF retry in RemapFs handles one handle at a time via fh()". In reality,fh()only returnsfh_inand no code path ever remapsfh_out. Updated to accurately document this as a known limitation with a TODO.cargo fmtissue in remap.rs — Longerror!()macro call on line 542 wasn't split across lines per rustfmt rules.Changes
fuse-pipe/src/protocol/request.rs: Updated comment onwith_fh()CopyFileRange/RemapFileRange arm to accurately reflect thatfh_outis NOT remapped (known limitation, not handled by EBADF retry)fuse-pipe/src/server/remap.rs: Reformattederror!()call inrestore_from_table()to passcargo fmtGenerated by Claude | Review Run