Open
Conversation
Owner
|
if i had to guess, i would expect a |
Owner
|
i just reviewed the vcluster create command logic. if the --kubernetes-version flag is not provided explicitly, it defaults to the k8s version of the host cluster, obtained from the client config. i don't think this code change is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
control exactly the k8s version of virtual clusters (vclusters).
Description:
When defining
k8s_versionvariable at config.yaml, it was only used to define it for the k3d cluster (the base cluster), but not for vclusters, where tsb actually runs. The vcluster version was the default onev1.25.14of vclustervcluster version 0.16.3.