Skip to content

Vulnerability fix (powered by Mobb Autofixer) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eitanMobb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Vulnerability fix (powered by Mobb Autofixer) #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb594fd
mobb fix commit: 68793482-e2a0-46ad-b85c-ce8a265288eb
May 17, 2024
919ecb1
mobb fix commit: 4b1575ce-a243-4693-a332-4c1117168699
May 17, 2024
4af5b09
mobb fix commit: 63558f30-a6b0-4d86-a0e4-93e1e0526217
May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/owasp/webgoat/container/AsciiDoctorTemplateResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import org.thymeleaf.templateresolver.FileTemplateResolver;
import org.thymeleaf.templateresource.ITemplateResource;
import org.thymeleaf.templateresource.StringTemplateResource;
import org.springframework.web.util.HtmlUtils;

/**
* Thymeleaf resolver for AsciiDoc used in the lesson, can be used as follows inside a lesson file:
Expand Down Expand Up @@ -161,7 +162,7 @@ private String determineLanguage() {
} else {
String langHeader = request.getHeader(Headers.ACCEPT_LANGUAGE_STRING);
if (null != langHeader) {
log.debug("browser locale {}", langHeader);
log.debug("browser locale {}", HtmlUtils.htmlEscape(String.valueOf(langHeader).replace("\n", "").replace("\r", "")));
return langHeader.substring(0, 2);
} else {
log.debug("browser default english");
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/owasp/webgoat/lessons/cryptography/SigningAssignment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.ResponseBody;
import org.springframework.web.bind.annotation.RestController;
import org.springframework.web.util.HtmlUtils;

@RestController
@AssignmentHints({
Expand Down Expand Up @@ -78,7 +79,7 @@ public AttackResult completed(
}
if (!DatatypeConverter.printHexBinary(rsaPubKey.getModulus().toByteArray())
.equals(tempModulus.toUpperCase())) {
log.warn("modulus {} incorrect", modulus);
log.warn("modulus {} incorrect", HtmlUtils.htmlEscape(String.valueOf(modulus).replace("\n", "").replace("\r", "")));
return failed(this).feedback("crypto-signing.modulusnotok").build();
}
/* orginal modulus must be used otherwise the signature would be invalid */
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/owasp/webgoat/webwolf/requests/LandingPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.util.HtmlUtils;

@Controller
@Slf4j
Expand All @@ -45,7 +46,7 @@ public class LandingPage {
})
public Callable<ResponseEntity<?>> ok(HttpServletRequest request) {
return () -> {
log.trace("Incoming request for: {}", request.getRequestURL());
log.trace("Incoming request for: {}", HtmlUtils.htmlEscape(String.valueOf(request.getRequestURL()).replace("\n", "").replace("\r", "")));
return ResponseEntity.ok().build();
};
}
Expand Down