Open
Conversation
Replaces flat x_custom_field mangling with structured icalendar property using jCal format (RFC 7265) for iCal→gnomon import, and JSPROP emission for JSCalendar vendor properties in gnomon→iCal export. Adds ~15 missing JSCalendar export mappings (locations, participants, recurrenceRules, links, relatedTo, created, updated, etc.) and warnings for unrecognised non-vendor fields. Closes #90, closes #50, closes #54. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix weekday string mismatch in build_jscal_rrule ("mo" → "monday")
- Extract import_value_to_json as ImportValue::to_json() method
- Deduplicate calendar-level x-property handling via XPropertySink for Calendar
- Deduplicate build_participants/build_task_participants via macro
- Extract magic strings to constants (ICALENDAR_FIELD, JSPROP_NAME, JSPTR_PARAM)
- Add @type and name fields to ICalComponent records
- Implement convertedProperties: preserve unknown params on known iCal properties
through the gnomon import/export round-trip
- Remove empty components field from ICalComponent when unused
- Add tests for all changes
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The iCalendar TRANSP property was being translated to/from "opaque" and "transparent" strings, but the spec and shape validator expect the JSCalendar convention of "busy" and "free". Also fixes the spec mapping table which incorrectly named the target field "transparency". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Same issue as the TRANSP fix: iCalendar CLASS:CONFIDENTIAL was being lowercased directly to "confidential" instead of translated to the JSCalendar/Gnomon value "secret". Also corrects the spec mapping tables to use the field name "privacy" (matching JSCalendar) instead of "class". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
get_datetime now handles flat date records {year, month, day} from
date-only DTSTART values, matching the iCalendar export's existing
behavior. The icalendar field is preserved in JSCalendar output without
a spurious unrecognised-field warning.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x_custom_fieldmangling with a structuredicalendarproperty using jCal format (RFC 7265). X-properties now preserve their original name, parameters, value type, and value as[name, params, type, value]arrays undericalendar.properties.icalendar.propertiesback to iCalendar X-properties on export. JSCalendar vendor properties (containing:) are emitted asJSPROP;JSPTR="key":json_valueper draft-ietf-calext-jscalendar-icalendar-22.prefix:nameconvention).Breaking changes
x_*flat fields on imported iCalendar records are replaced by the structuredicalendarproperty. Any code or gnomon files that referencex_custom_fieldstyle keys from iCalendar imports will need updating.Test plan
icalendar.propertiesstructure → export → verify X-properties matchcom.example:foo) → export iCal → verify JSPROP emissionCloses #90, closes #50, closes #54.
🤖 Generated with Claude Code