fix: replace per-token String with byte range#83
Merged
Conversation
Token now stores a Range<usize> span instead of an owned String, eliminating one heap allocation per token during lexing. The token text is derived on demand by slicing the original source string. Closes #16 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tokenstruct to storespan: Range<usize>instead oftext: String, eliminating one heap allocation per token during lexingToken::text(&self, source: &str) -> &strmethod to derive token text on demand by slicing the original source stringParserto carry the source string and usetok.text(&self.source)instead of&tok.textoffsetfield fromParser; byte offsets are now read directly from token spansTest plan
cargo test --workspace)tok.span.clone()instead of manual offset tracking)Closes #16
🤖 Generated with Claude Code