fix: avoid unnecessary allocation in preprocess#82
Merged
Conversation
Return Cow<str> instead of String so that typical source files (no BOM, no CRLF, no shebang) take a zero-allocation fast path. BOM removal also avoids allocation since it is a simple slice operation. Closes #19 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preprocess()return type fromStringtoCow<'_, str>Cow::Borrowedwhen the input has no BOM, no CRLF sequences, and no shebang -- the common case for typical source filesBorrowed), only CRLF normalization and shebang stripping allocate (Owned)Cow<str>derefs to&strtransparentlyBorrowed/OwnedbehaviorTest plan
Cow<str>is compatible with existingassert_eq!comparisons)Closes #19
🤖 Generated with Claude Code