Update for changes in ZIP 234 and initial supply value#3
Open
daira wants to merge 5 commits intoeigerco:mainfrom
Open
Update for changes in ZIP 234 and initial supply value#3daira wants to merge 5 commits intoeigerco:mainfrom
daira wants to merge 5 commits intoeigerco:mainfrom
Conversation
In particular, according to ZIP 234 the deployment occurs only once the NSM subsidy would drop below the legacy subsidy, and so the four-year periods used for comparison no longer line up with halving periods. Occurrences of ZSF have also been changed to NSM. The README has been updated with the new output, and a disclaimer added. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
In particular, this updates to a fixed version of the `font-kit` crate which had a memory safety bug. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
changed the title
Update initial supply value
asmie
requested changes
Feb 5, 2026
| This fork of Eiger's "[ZSF simulator](https://github.com/eigerco/zsf-simulator)" has been | ||
| significantly modified by me, Daira-Emma Hopwood. Any errors in the interpretation of | ||
| ZIP 234 are my own. | ||
|
|
Member
There was a problem hiding this comment.
This wording makes sense in your fork, but it will read a bit oddly once we merge it back into the upstream repo.
Could you instead add the “Contributors” section now, and keep that note for the point when you add it? Then after the merge it’ll still read naturally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, according to ZIP 234 the deployment occurs only once the NSM subsidy would drop below the legacy subsidy, and so the four-year periods used for comparison no longer line up with halving periods. Occurrences of ZSF have been changed to NSM.
This also updates INITIAL_SUPPLY to take into account unclaimed mining rewards up to the second halving, according to
zcash-cli getblock 2726399 | jq '.chainSupply'. After the second halving, which coincides with NU6 and activation of ZIP 236, there can be no further unclaimed mining rewards.The README has been updated with the new output, and a disclaimer added. The vertical scale of the graphs has also been adjusted so that the curve uses more of the space.
Dependencies have been updated, primarily to update to a version of the
font-kitcrate that fixes a memory safety bug.