Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades two core dependencies for improved compatibility with newer compiler versions: fmt library from version 10.x to 11.x series (specifically 11.2.0 or newer within 11.x), and spdlog from 1.14.1 to 1.15.2 or newer. These upgrades are necessary to support the newer Clang versions introduced in PR #88.
Key Changes
- Upgraded fmt version constraint from
@10.2.1:10to@11.2.0:11with bounded major version - Upgraded spdlog version constraint from
@1.14.1to@1.15.2:with open-ended constraint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veprbl
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR upgrades fmt to 11.2.0 (or newer, within 11.*) and spdlog to 1.15.2 (or newer). This will add compatibility with the newer clang versions in #88.
Needs:
whenare merged with non-test dependencies spack/spack#51775 or gaudi: workaround test-dependency bug with awhenspack/spack-packages#2825What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.