Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the eic-opticks package to the CUDA-enabled EIC container environment, leveraging OptiX for GPU-accelerated optical photon simulation. The change depends on eic-spack PR #824 to provide the package definition.
Changes:
- Added eic-opticks package version specification in packages.yaml
- Added eic-opticks to cuda environment spec list
- Updated eic-spack version to commit that includes eic-opticks support
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spack-environment/packages.yaml | Pins eic-opticks to specific git commit hash (7057d7bd7f755253c416b813e59f0af28de98ddc) |
| spack-environment/cuda/spack.yaml | Adds eic-opticks to CUDA environment package list in alphabetical order |
| eic-spack.sh | Updates EICSPACK_VERSION to commit containing eic-opticks package definition with FIXME note about pending merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses eic/eic-spack#824 to provide an opticks installation for eic-shell.