Skip to content

fix: ensure spack env exists before activation #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plexoos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ensure spack env exists before activation #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions containers/eic/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ ENV GIT_TERMINAL_PROMPT=0
# Concretization (default environment)
RUN <<EOF
set -e
spack env create ${ENV}
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spack env create ${ENV} command is incorrect and unnecessary. The command creates a named environment 'xl' (from ${ENV}), but line 56 activates a directory-based environment at /opt/spack-environment/xl (from ${SPACK_ENV}). These are two different concepts in Spack. The directory-based environment already exists with a valid spack.yaml file copied from the build context on line 44, so spack env activate --dir can be used directly without prior creation. This pattern is consistently used elsewhere in the Dockerfile (lines 176, 281, 320) where environments are activated without creation. The added command should be removed.

Suggested change
spack env create ${ENV}

Copilot uses AI. Check for mistakes.
spack env activate --without-view --dir ${SPACK_ENV}
spack concretize --force
spack --color=never find --long --no-groups --show-concretized --format "{name}" \
Expand Down
Loading