Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade the py-torch package requirement from version 2.5.1 to version 2.7.1 or later, with the stated goals of unpinning py-sympy used by acts and supporting newer CUDA versions.
Key Changes:
- Modified py-torch version constraint from a pinned version '@2.5.1' to a minimum version requirement '@2.7.1:'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
commented
Jan 5, 2026
veprbl
approved these changes
Jan 5, 2026
wdconinc
force-pushed
the
py-torch-2.7.1
branch
from
c568e7f to
d87bd16
Compare
Contributor
Author
|
Despite the cxxflags, there are still incompatible-pointer type errors for arm64, https://github.com/eic/containers/actions/runs/21119912284/job/60731083339?pr=111#step:15:9469. It is possible the flag is not passed, or overridden by pytorch. |
wdconinc
commented
Jan 19, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
py-torch-2.7.1
branch
from
da26ea4 to
e5e73e9
Compare
Contributor
Author
|
PyTorch 2.9.0 failure with GCC-14 is also at pytorch/pytorch#172445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR upgrades py-torch to 2.7.1 or later (to unpin py-sympy used by acts, and to support newer CUDA).