the host of the assets,if not set,it will be 127.0.0.1:${devServer.port} in development#33
Open
daolou wants to merge 6 commits intoeggjs:masterfrom
Open
the host of the assets,if not set,it will be 127.0.0.1:${devServer.port} in development#33daolou wants to merge 6 commits intoeggjs:masterfrom
127.0.0.1:${devServer.port} in development#33daolou wants to merge 6 commits intoeggjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
===========================================
- Coverage 100.00% 99.49% -0.51%
===========================================
Files 10 10
Lines 196 198 +2
===========================================
+ Hits 196 197 +1
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Author
|
@popomore |
popomore
requested changes
May 26, 2019
Member
popomore
left a comment
There was a problem hiding this comment.
Add a testcase and delete the package-lock
Member
|
If use autoPort, how to specify the port in config |
Author
this: In addition, if someone want use himself url, in that case, he/she should know the port. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Case:
domain 127.0.0.1to/etc/hostsdomainSo, if it setted the url, it will be it, if it not set the url, then use default
127.0.0.1