Skip to content

Conversation

@simonpasquier
Copy link
Contributor

This commit also replaces the --store argument by --endpoint for Thanos Querier. The new argument is available since v0.24.0 but has been removed in v0.38.0.

This commit also replaces the `--store` argument by `--endpoint` for
Thanos Querier. The new argument is available since v0.24.0 but has been
removed  in v0.38.0.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Copy link
Collaborator

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonpasquier
Copy link
Contributor Author

whoa the CI is broken due to very old GH actions 😅
setting up a dependabot config would be handy...

@saswatamcode
Copy link
Collaborator

Yup we should, do you mind bumping the actions

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Contributor Author

ah I forgot one occurrence but it should be fixed now (we should also probably upgrade the Go versions).

@saswatamcode
Copy link
Collaborator

So only macOS seems broken here on CI! Let's fix in next PR!

@saswatamcode saswatamcode merged commit 44570aa into efficientgo:main Dec 4, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants