Skip to content

checks/magic: index arguments from end#187

Open
proppy wants to merge 1 commit intoefabless:mainfrom
proppy:magic-fix-index
Open

checks/magic: index arguments from end#187
proppy wants to merge 1 commit intoefabless:mainfrom
proppy:magic-fix-index

Conversation

@proppy
Copy link

@proppy proppy commented Feb 10, 2023

Fixes #186

Copy link
Contributor

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for the way the script is called on the magic command line from the python script; the arguments passed to the Tcl script will always be at the end, and any arguments to magic will be at the beginning. This is unlikely to change, but I agree that counting from the end is a bit more robust.

@marwaneltoukhy
Copy link
Contributor

@RTimothyEdwards Is this still correct? Shall we merge it?

@RTimothyEdwards
Copy link
Contributor

@marwaneltoukhy : Yes, I think it is still relevant and as I said above it makes more sense for the arguments to be counted from the end backwards. Merging it should not affect script function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

magic tcl script should use proper argument parsing

3 participants