update typing for StringifyOptions["lineWidth"] to match comment#17
Merged
eemeli merged 1 commit intoeemeli:mainfrom May 13, 2025
Conversation
eemeli
approved these changes
May 13, 2025
Owner
eemeli
left a comment
There was a problem hiding this comment.
Yup, that looks appropriate. The alternative would've been to change the comment to say something like "use 0 to disable", as that would work as well.
The 80 in 80 | number is indeed unnecessary, but also apparently ignored. I can't recall for sure, but there may have been some tooling around when I wrote this that showed the raw expression in autocompletion, where it'd hint at the default value.
Styling the comments as /** ... */ before each option instead of // ... would I think get them picked up by tools, which might be nice. The comment would also be a more appropriate place to indicate the default value. I'd be happy to review another PR making such a change... 😇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16