Fix some minor issues in notebook of lecture 4.#41
Open
anusser wants to merge 1 commit intoee227c:masterfrom
Open
Fix some minor issues in notebook of lecture 4.#41anusser wants to merge 1 commit intoee227c:masterfrom
anusser wants to merge 1 commit intoee227c:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for creating such nice lecture material and making it publicly available.
While using the notebook of lecture 4, I found some (what I believe are) minor issues, which I fixed. As diffs of notebooks are unfortunately quite messy, I cleaned it up and I list the important changes in the diff below. I guess the only change that needs explanation is the last one. For tuning the gradient descent step size using gradient descent, I use the average point (i.e.,
sum(xs)/len(xs)) instead of the last one (i.e.,xs[-1]). This gives a better result I believe.If you have questions regarding other changes, feel free to ask. :)