-
Notifications
You must be signed in to change notification settings - Fork 1
fix: redacting user retirement data in lms #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for tracking Jenkins build numbers when cleaning up user retirement data in the LMS. The change enables the retirement cleanup process to associate a specific Jenkins job run with the retirement records being processed.
Changes:
- Added optional
jenkins_run_idparameter to track the Jenkins BUILD_NUMBER during retirement cleanup operations - Updated the cleanup functions to pass the Jenkins run ID through to the LMS API
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tubular/scripts/retirement_archive_and_cleanup.py | Added jenkins_run_id parameter to archive_and_cleanup CLI command and _cleanup_retirements_or_exit function |
| tubular/edx_api.py | Modified bulk_cleanup_retirements method to accept and conditionally include jenkins_run_id in API request payload |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
tubular/tests/test_retirement_archive_and_cleanup.py:27
- The
_call_scripthelper function doesn't support passing the newrun_idparameter, which means there's no test coverage for the new feature whenrun_idis actually provided (non-None). Consider adding arun_idparameter to this helper function and adding a test case that verifies therun_idis correctly passed through the entire flow.
def _call_script(cool_off_days=37, batch_size=None, dry_run=None, start_date=None, end_date=None):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Added jenkins_run_id parameter support for user retirement cleanup to enable traceability between Jenkins jobs and redacted retirement records.
Related Ticket
https://2u-internal.atlassian.net/browse/BOMS-293