"fix: revert remove Dockerfile syntax declaration" #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcapphelix
approved these changes
Jan 16, 2026
amits-2u
deleted the
revert-191-amits-2u/disable-buildKit-dockerfile-syntax
branch
There was a problem hiding this comment.
Pull request overview
This PR reverts the removal of the Dockerfile syntax declaration in edx-platform.Dockerfile. The syntax declaration is necessary because this Dockerfile uses BuildKit-specific features such as RUN --mount=type=secret for handling GitHub authentication tokens during the build process.
Changes:
- Re-adds
# syntax=docker/dockerfile:1directive to edx-platform.Dockerfile
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #191