Skip to content

Conversation

@deborahgu
Copy link
Member

we should use our fork of openedx translations for edxapp prod (ec2). not bothering to parameterize this because ec2 is not long for this world.

FIXES: AU-2734


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

we should use our fork of openedx translations. not bothering to parameterize this because ec2 is not long for this world.

FIXES: AU-2734
Copilot AI review requested due to automatic review settings December 15, 2025 22:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to configure the Atlas translation system to use a forked version of the openedx-translations repository for the edxapp production EC2 deployment. The change adds an environment variable to specify a custom repository and revision when pulling translations.

  • Adds ATLAS_OPTIONS environment variable export to configure translation source
  • Specifies repository and branch for Atlas translation pulls
  • Hardcodes the configuration specifically for EC2 (acknowledged as temporary)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- name: "Pull translations using Atlas"
shell: |
source "{{ edxapp_venv_dir }}/bin/activate"
export ATLAS_OPTIONS="--repository=edx/openedx-translations --revision=main"
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states the intention is to "use our fork of openedx translations," but the repository specified here is "edx/openedx-translations" which appears to be the upstream repository, not a fork. If the goal is to use a forked version, the repository should be changed to point to your organization's fork (e.g., "yourorg/openedx-translations"). Please verify this is the correct repository reference.

Suggested change
export ATLAS_OPTIONS="--repository=edx/openedx-translations --revision=main"
export ATLAS_OPTIONS="--repository=yourorg/openedx-translations --revision=main"

Copilot uses AI. Check for mistakes.
@deborahgu deborahgu merged commit ee8a7d1 into master Dec 17, 2025
9 checks passed
@deborahgu deborahgu deleted the dkaplan1/AU-2734_switch-edxapp-local-translations-for-k8s-and-ansible branch December 17, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants