Skip to content

chore: Update NGINX_HSTS_MAX_AGE for edxapps. ENT-11139 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macdiesel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Update NGINX_HSTS_MAX_AGE for edxapps. ENT-11139 #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ NGINX_ENABLE_SSL: False
NGINX_REDIRECT_TO_HTTPS: False
# Disable handling IP disclosure for private IP addresses. This is needed by ELB to run the health checks while using `NGINX_ENABLE_SSL`.
NGINX_ALLOW_PRIVATE_IP_ACCESS: False
NGINX_HSTS_MAX_AGE: 31536000
NGINX_HSTS_MAX_AGE: 63072000
# Set these to real paths on your
# filesystem, otherwise nginx will
# use a self-signed snake-oil cert
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/cms.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ error_page {{ k }} {{ v }};

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

# prevent the browser from doing MIME-type sniffing
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/conductor.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ server {

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

listen {{ CONDUCTOR_NGINX_PORT }} {{ default_site }};
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/edx_notes_api.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ server {

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

{% include "common-settings.j2" %}
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/insights.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ server {

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

location ~ ^/static/(?P<file>.*) {
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/learner_portal.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ server {
server_name ~^((stage|prod)-)?learner-portal.*;
ssl_certificate /etc/ssl/certs/wildcard.sandbox.edx.org.pem;
ssl_certificate_key /etc/ssl/private/wildcard.sandbox.edx.org.key;
add_header Strict-Transport-Security "max-age=31536000; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
location / {
root /edx/app/learner_portal/learner_portal/dist;
index index.html;
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/lms.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ error_page {{ k }} {{ v }};

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

# prevent the browser from doing MIME-type sniffing
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/program_console.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ server {
server_name ~^((stage|prod)-)?program-console.*;
ssl_certificate /etc/ssl/certs/wildcard.sandbox.edx.org.pem;
ssl_certificate_key /etc/ssl/private/wildcard.sandbox.edx.org.key;
add_header Strict-Transport-Security "max-age=31536000; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
location / {
root /edx/app/program-console/program-console/dist;
index index.html;
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/prospectus.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ server {

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}


Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/nginx/templates/edx/app/nginx/sites-available/xqueue.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ server {

{% if NGINX_ENABLE_SSL or NGINX_REDIRECT_TO_HTTPS %}
# request the browser to use SSL for all connections
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}";
add_header Strict-Transport-Security "max-age={{ NGINX_HSTS_MAX_AGE }}; includeSubDomains; preload";
{% endif %}

# set xqueue upload limit to 20MB to match the LMS upload limit.
Expand Down