chore: cleanup of mktg urls link map #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated MKTG_URL_LINK_MAP configuration variable from all edxapp configuration files, cleaning up unused configuration as part of internal maintenance work.
- Removed
EDXAPP_MKTG_URL_LINK_MAPdefault variable definition - Removed
MKTG_URL_LINK_MAPfrom generic environment configuration - Removed
MKTG_URL_LINK_MAPfrom Docker build configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| playbooks/roles/edxapp/defaults/main.yml | Removed EDXAPP_MKTG_URL_LINK_MAP variable definition and its usage in generic environment config |
| docker/build/edxapp/studio.yml | Removed MKTG_URL_LINK_MAP configuration entry |
| docker/build/edxapp/lms.yml | Removed MKTG_URL_LINK_MAP configuration entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup of MKTG_URL_LINK_MAP from internal repo
Related Ticket
https://2u-internal.atlassian.net/browse/BOMS-215