Open
Conversation
edumorlom
reviewed
Jun 22, 2024
| }; | ||
|
|
||
|
|
||
| const getPasswordStrength = () => { |
Owner
There was a problem hiding this comment.
Instead of reruning differet componnets you can return one component and change the style and text directly.
case 2:
const clsName = "high"
const text = "High"
case 1:
const clsName = "Medium"
const text = "Medium"
etc...
return <Text className={clsName}>{text]</Text>
edumorlom
reviewed
Jun 22, 2024
| } else if (passwordStrength === 0) { | ||
| alert("Password is too weak. Please choose a stronger password."); | ||
| } else if (passwordStrength === 1) { | ||
| Alert.alert( |
Owner
There was a problem hiding this comment.
For alers, i would use the translate function so that we can use spanish and english and creole texts depending on the language
edumorlom
reviewed
Jun 22, 2024
| @@ -0,0 +1,1005 @@ | |||
| // nuMom/src/Components/poorPasswords.js | |||
| const poorPasswords = [ | |||
Owner
There was a problem hiding this comment.
As an improvment, instead of hardcoding this. You could use fetch method and dynamically get the file from the URL
edumorlom
reviewed
Jun 22, 2024
Owner
edumorlom
left a comment
edumorlom
left a comment
There was a problem hiding this comment.
Looks good! left some comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.